Review Request 112799: Add "collab editing" action to kpeople actions plugin

David Edmundson david at davidedmundson.co.uk
Wed Sep 18 20:32:20 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112799/#review40308
-----------------------------------------------------------



KTp/contact.h
<http://git.reviewboard.kde.org/r/112799/#comment29745>

    Just as side note: long time I want this to  return a list of shared tubes, so we don't have to hardcode each tube into the main lib.
    
    There was an idea to replace all this with Tp::Capabilities() sharedCaps(). which will do all that.
    
    Probably not worth changing no3.


- David Edmundson


On Sept. 18, 2013, 5:27 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112799/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 5:27 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Pretty simple, I guess.
> 
> 
> Diffs
> -----
> 
>   KTp/contact.h 7173686e0590c22db4d53ab2550f64891c030acb 
>   KTp/contact.cpp c9f857bdfa96bd3a21bf3912b6dbb8f3be3e7fe5 
>   kpeople/actionsplugin/CMakeLists.txt 3f2bc9a6c27b1263bd916b8c7da0c60930d43a0f 
>   kpeople/actionsplugin/kpeople-actions-plugin.cpp f5f838287326a4d1ab324e566ac8114167e231da 
> 
> Diff: http://git.reviewboard.kde.org/r/112799/diff/
> 
> 
> Testing
> -------
> 
> Action appears in context menu and starts collab editing.
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130918/6ed68ae8/attachment.html>


More information about the KDE-Telepathy mailing list