Review Request 112361: Add Actions for starting collaborative editing

[Sven Brauch]

> On Aug. 29, 2013, 6:41 p.m., Aleix Pol Gonzalez wrote:
> > What about KPeople?
> 
> Sven Brauch wrote:
>     What about it?
> 
> David Edmundson wrote:
>     Good comment.
>     
>     There's a plugin for kpeople (kpeople/actions) which lists actions which can be started on a contact. 
>     It can call KTp::Actions() so it's just a few lines to hook it in there.
>     
>     Long term, I want actions for KTp to be generated on the fly. The kpeople plugin will then just call that. 
>
> 
> Sven Brauch wrote:
>     Alright, I'll take care of it.
> 
> Sven Brauch wrote:
>     I just wanted to do this, and noticed the file which contains the logic for creating the channel requests (which is not very complicated but not entirely trivial either) is again in the wrong place, which is ktp-common-internals. To add support for this to kpeople, I'd need to copy the file there... except if anyone has a better idea?
> 
> David Edmundson wrote:
>     and the place you need to add the action is ktp-common-internals (the kpeople/actions of k-c-i)

Now I feel pretty dumb.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112361/#review38885
-----------------------------------------------------------


On Aug. 29, 2013, 3:23 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112361/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 3:23 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Adds actions for starting collaborative editing requests with both contacts and chatrooms. Should be straight-forward to use.
> 
> Used by the text-ui review request I just submitted.
> 
> 
> Diffs
> -----
> 
>   KTp/actions.h 8546f51 
>   KTp/actions.cpp df21dff 
> 
> Diff: http://git.reviewboard.kde.org/r/112361/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130918/3dd969dd/attachment.html>