Review Request 112790: Fix ktp-text-ui not displaying incomming messages when ktplogger plugins are missing

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112790/#review40257
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Sept. 18, 2013, 8:17 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112790/
> -----------------------------------------------------------
> 
> (Updated Sept. 18, 2013, 8:17 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> The problem is that when PendingOperation is created and there are no plugins, it emits finished() signal right away from it's constructor, so the signal is never caught, because we connect to it after the operation is created.
> 
> This patch ensures that the signal is emitted after next event loop iteration.
> 
> 
> This addresses bug 325026.
>     http://bugs.kde.org/show_bug.cgi?id=325026
> 
> 
> Diffs
> -----
> 
>   KTp/Logger/pending-logger-operation.h e6a46f2 
>   KTp/Logger/pending-logger-operation.cpp c767a7c 
> 
> Diff: http://git.reviewboard.kde.org/r/112790/diff/
> 
> 
> Testing
> -------
> 
> Removed all KTpLogger plugins and tried to receive messages - all worked.
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130918/0d5e1d5f/attachment.html>