Review Request 112688: Use more sensible icons for the toolbar

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112688/
-----------------------------------------------------------

(Updated Sept. 17, 2013, 5:04 p.m.)


Review request for Telepathy.


Changes
-------

New suggestion for icons, as announced. I moved the "Group chat" button to the toolbar, it uses the "IRC" icon (not perfect semantically but should be ok, since IRC is very group-chatty -- and the default icon, which 99% of users will see, is perfect), and the "Show grouped" to the menu instead. Also contains the new "Show offline" icon, which I'll add to kci if you approve.

This brings up the question, do we need sizes other than 22x22 for it? I.e. can the toolbar icons be displayed in a different size?


Description
-------

Use more sensbile icons for the toolbar. See screenshot. Main problems which I wanted to address:
 * The "merge contacts" icon looks like it adds a contact.
 * The "show grouped" icon is the "edit-group" icon which makes no sense and also looks weird
 * The "show offline" icon is the "meeting-attending-tentative" which makes a) no sense and b) looks like it's disabled all the time.


Diffs (updated)
-----

  main-widget.cpp 5f2557e 

Diff: http://git.reviewboard.kde.org/r/112688/diff/


Testing
-------

Nothing breaks by changing icons, does it?


File Attachments (updated)
----------------

Suggested new icons, with "split group" icon
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons.png
Suggested new icons, with "group contacts" icon
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons2.png
new "show offline" icon
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/icons4.png
New icons, next iteration
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/17/newicons.png


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130917/153d3d45/attachment.html>