Review Request 112753: Don't install text-ui lib headers

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112753/#review40228
-----------------------------------------------------------

Ship it!


...if this does not break logger.

- Martin Klapetek


On Sept. 15, 2013, 9:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112753/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 9:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Don't install text-ui lib headers
> 
> I had this weird idea that other people would want to use the AdiumTheme classes I made, and that this would be used for embedding the text-ui into other apps (kwhiteboard etc).
> 
> I was wrong.
> 
> We're making steps to doing this properly with a KPart which will hopefully later inherit an interface that we put in ktp-common-internals.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 547c56046117b1ef5f57f41345098a6539fa3674 
>   lib/KTp/AdiumThemeContentInfo 68aa6350ebbbec2857d1a251173995475120cd37 
>   lib/KTp/AdiumThemeHeaderInfo e8c8f6a85d6fb315e0629d227d3bf4037bbb4abb 
>   lib/KTp/AdiumThemeMessageInfo 922f4dca4feae1ef4d79d21ee9f22c5d07158317 
>   lib/KTp/AdiumThemeStatusInfo b0b9db4484bc8aea92210d5df2b7f57eed860752 
>   lib/KTp/AdiumThemeView a30f4cfa8ee74c4a05c97ccf89d085f04436ae6f 
>   lib/KTp/ChatStylePlistFileReader ed858b191e48d257170c48fdfe8ab2c20269faf3 
>   lib/KTp/ChatWidget 902ca640fa3d0f0df7832c5e64b47dbc43d1827b 
>   lib/KTp/ChatWindowStyle b434b07ff5a3f48a8ddf3b433b018afa31d383f3 
>   lib/KTp/ChatWindowStyleManager fbfb6e385e037220562738382dda62eb6e18cf78 
>   lib/KTp/TextChatConfig bcc64a22b351783746f7a932f4b53d0a67e79230 
> 
> Diff: http://git.reviewboard.kde.org/r/112753/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130917/53738e5c/attachment.html>