Review Request 112688: Use more sensible icons for the toolbar

[David Edmundson]

> On Sept. 14, 2013, 8:10 p.m., Sven Brauch wrote:
> > What about this? I agree it's not perfect but I still think it's a significant improvement.
> > 
> > I can either make the "show offline" icon as suggested look properly (we can include our own icon, right?), or we can leave that icon unchanged and just go with a subset of the other changes...
> > But at least the "merge contact" I'd really vote for changing.
> > 
> > Cheers,
> > Sven
> 
> Martin Klapetek wrote:
>     merge contact icon - totally for it.
>     offline/online contacts - somewhat works...I'd be pretty much ok with it
>     group icon - I don't like that much, not sure if we can find anything better though

We could move it to the menu. Then you don't need an icon.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112688/#review40029
-----------------------------------------------------------


On Sept. 12, 2013, 7:16 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112688/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 7:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use more sensbile icons for the toolbar. See screenshot. Main problems which I wanted to address:
>  * The "merge contacts" icon looks like it adds a contact.
>  * The "show grouped" icon is the "edit-group" icon which makes no sense and also looks weird
>  * The "show offline" icon is the "meeting-attending-tentative" which makes a) no sense and b) looks like it's disabled all the time.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp 5f2557e 
> 
> Diff: http://git.reviewboard.kde.org/r/112688/diff/
> 
> 
> Testing
> -------
> 
> Nothing breaks by changing icons, does it?
> 
> 
> File Attachments
> ----------------
> 
> Suggested new icons, with "split group" icon
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons.png
> Suggested new icons, with "group contacts" icon
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons2.png
> new "show offline" icon
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/icons4.png
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130916/90fc25e5/attachment-0001.html>