Review Request 112739: [logviewer] Open logs for contact/person passed via command line arguments

David Edmundson david at davidedmundson.co.uk
Sun Sep 15 14:26:54 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112739/#review40066
-----------------------------------------------------------


I'm confused. This seems to contain some other unrelated changes. 
Could you explain them?

- David Edmundson


On Sept. 15, 2013, 1:21 p.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112739/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2013, 1:21 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Fixes opening of a contact (when account ID and contact ID are passed via cmd line) and add support for opening a person/contact when a Nepomuk URI is passed via cmd line
> 
> 
> This addresses bug 324918.
>     http://bugs.kde.org/show_bug.cgi?id=324918
> 
> 
> Diffs
> -----
> 
>   logviewer/dates-model.h 14d2eae 
>   logviewer/dates-model.cpp 195765f 
>   logviewer/entity-filter-model.cpp 356e3d6 
>   logviewer/entity-view.h 18bf9d5 
>   logviewer/entity-view.cpp 77fefc0 
>   logviewer/log-viewer.h b3a53f0 
>   logviewer/log-viewer.cpp 8b2e779 
>   logviewer/person-entity-merge-model.h c07e066 
>   logviewer/person-entity-merge-model.cpp 0fcff92 
> 
> Diff: http://git.reviewboard.kde.org/r/112739/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130915/88913cf7/attachment.html>


More information about the KDE-Telepathy mailing list