Review Request 112704: Set presence when account back online

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112704/#review39928
-----------------------------------------------------------


I'm a bit lost on this (and your last two related patches "fixing" this)

In my email reply on the thread you linked to I suggest we can simply make a one line change in TelepathyModule::setPresence which will fix the original problem restoring from away without the need for hacks.

I may be wrong, but I want to know why that won't work before we proceed to add yet more code on top.

- David Edmundson


On Sept. 12, 2013, 7:53 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112704/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 7:53 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Some discussion in this thread: http://mail.kde.org/pipermail/kde-telepathy/2013-September/009951.html
> 
> This patch will listen on onlinenessChange and setRequestPresence to account when account back online.
> 
> 
> Diffs
> -----
> 
>   telepathy-module.h f39e006 
>   telepathy-module.cpp 57904b2 
> 
> Diff: http://git.reviewboard.kde.org/r/112704/diff/
> 
> 
> Testing
> -------
> 
> add an account with wrong password. lock screen, bad account still offline and no dialog popup.
> suspend and relogin, account doesn't keep always away.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130912/e0f8ec83/attachment.html>