Review Request 112705: set presence should only be done on user action

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112705/#review39926
-----------------------------------------------------------


Makes sense. Given the deliberate two signal handlers, I wonder why we didn't have it like that before.

- David Edmundson


On Sept. 12, 2013, 7:52 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112705/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 7:52 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> add one account with wrong password, lock screen to trigger auto away, dbus messages shows that contact list set the requestedpresence to all account, caused by setPresence in onCurrentIndexChanged instead of activated.
> 
> 
> Diffs
> -----
> 
>   global-presence-chooser.cpp 55a30b9 
> 
> Diff: http://git.reviewboard.kde.org/r/112705/diff/
> 
> 
> Testing
> -------
> 
> now lock screen doesn't bring bad account online.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130912/e2545363/attachment-0001.html>