Review Request 112688: Use more sensible icons for the toolbar
Sven Brauch
svenbrauch at googlemail.com
Thu Sep 12 15:46:43 UTC 2013
> On Sept. 12, 2013, 3:45 p.m., Aleix Pol Gonzalez wrote:
> > File Attachment: Suggested new icons, with "group contacts" icon
> > <http://git.reviewboard.kde.org/r/112688/#fcomment105>
> >
> > What about this icon? xD what does it do :D
Well it starts a chat, so I think it's not too bad. Also I didn't change it! Not my fault.
- Sven
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112688/#review39891
-----------------------------------------------------------
On Sept. 12, 2013, 2:20 p.m., Sven Brauch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112688/
> -----------------------------------------------------------
>
> (Updated Sept. 12, 2013, 2:20 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Use more sensbile icons for the toolbar. See screenshot. Main problems which I wanted to address:
> * The "merge contacts" icon looks like it adds a contact.
> * The "show grouped" icon is the "edit-group" icon which makes no sense and also looks weird
> * The "show offline" icon is the "meeting-attending-tentative" which makes a) no sense and b) looks like it's disabled all the time.
>
>
> Diffs
> -----
>
> main-widget.cpp 5f2557e
>
> Diff: http://git.reviewboard.kde.org/r/112688/diff/
>
>
> Testing
> -------
>
> Nothing breaks by changing icons, does it?
>
>
> File Attachments
> ----------------
>
> Suggested new icons, with "split group" icon
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons.png
> Suggested new icons, with "group contacts" icon
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons2.png
>
>
> Thanks,
>
> Sven Brauch
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130912/4420c1e4/attachment.html>
More information about the KDE-Telepathy
mailing list