Review Request 112688: Use more sensible icons for the toolbar

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112688/#review39888
-----------------------------------------------------------



File Attachment: Suggested new icons, with "group contacts" icon
<http://git.reviewboard.kde.org//r/112688/#fcomment100>
    While technically correct, this feels strange - it shows folders + aligned in a row, we have neither :S


File Attachment: Suggested new icons, with "group contacts" icon
<http://git.reviewboard.kde.org//r/112688/#fcomment101>
    Not sure about this one either...I mean, I'm not sure what it's actually depicting :)

- Martin Klapetek


On Sept. 12, 2013, 2:20 p.m., Sven Brauch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112688/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 2:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Use more sensbile icons for the toolbar. See screenshot. Main problems which I wanted to address:
>  * The "merge contacts" icon looks like it adds a contact.
>  * The "show grouped" icon is the "edit-group" icon which makes no sense and also looks weird
>  * The "show offline" icon is the "meeting-attending-tentative" which makes a) no sense and b) looks like it's disabled all the time.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp 5f2557e 
> 
> Diff: http://git.reviewboard.kde.org/r/112688/diff/
> 
> 
> Testing
> -------
> 
> Nothing breaks by changing icons, does it?
> 
> 
> File Attachments
> ----------------
> 
> Suggested new icons, with "split group" icon
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons.png
> Suggested new icons, with "group contacts" icon
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/12/newicons2.png
> 
> 
> Thanks,
> 
> Sven Brauch
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130912/3fb0c9c7/attachment.html>