Review Request 112683: Toggle between no grouping and group by groups when in kpeople mode

[David Edmundson]

> On Sept. 12, 2013, 2:51 p.m., Martin Klapetek wrote:
> > contact-list-widget.cpp, lines 398-400
> > <http://git.reviewboard.kde.org/r/112683/diff/3/?file=189131#file189131line398>
> >
> >     Are you sure about this? ;)

No.. see what happened was..

I updated the review
I saw it in the review just after I hit publish
Fixed it
ran git commit --amend
Thought, I don't want people to see this mistake, I've got a ship it, I'll just push my fix.

My git commit --amend didn't include the fix, as I didn't git add first.
So I pushed this broken
I've fixed it since
You saw the mistake anyway

I am a n00b. Twice.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112683/#review39886
-----------------------------------------------------------


On Sept. 12, 2013, 2:03 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112683/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 2:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Toggle between no grouping and group by groups when in kpeople mode
> 
> Also this fixes expand when filtering.
> 
> Works but I'm worried it makes the codebase messy.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.h ba32451239d95c277feeeacfc2f5a4424b407c92 
>   contact-list-widget.cpp cf321313e63ed59f8a9f0976f6c0a78bbba1535b 
> 
> Diff: http://git.reviewboard.kde.org/r/112683/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130912/75a2fbcd/attachment.html>