Review Request 112683: Toggle between no grouping and group by groups when in kpeople mode

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112683/#review39879
-----------------------------------------------------------

Ship it!


> Works but I'm worried it makes the codebase messy.

Well that's to be expected when bending one thing for two backends. I think it's not so bad at this point....but comments! Add comments on why we need to set the root decorated to true when no groups are present.

- Martin Klapetek


On Sept. 12, 2013, 1:06 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112683/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2013, 1:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Toggle between no grouping and group by groups when in kpeople mode
> 
> Also this fixes expand when filtering.
> 
> Works but I'm worried it makes the codebase messy.
> 
> 
> Diffs
> -----
> 
>   contact-list-widget.cpp cf321313e63ed59f8a9f0976f6c0a78bbba1535b 
> 
> Diff: http://git.reviewboard.kde.org/r/112683/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130912/0f5edc44/attachment-0001.html>