Review Request 111387: Add merge/unmerge button to contact list toolbar

Commit Hook null at kde.org
Thu Sep 12 12:23:42 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111387/
-----------------------------------------------------------

(Updated Sept. 12, 2013, 12:23 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

Adds KDualAction to merge contacts into a metacontact or unmerge metacontacts. It still misses couple things (eg. getting the returned job and then the uri of new created person), but it's quite complex and I'd like to get early feedback on it.

There are many combinations that the user can select, main 9 ones (0 contacts, 1 contact, n contacts in combination with 0 persons, 1 person, n persons) plus cases like "contact is a subcontact of selected person", "contact is subcontact of different person" etc.


Diffs
-----

  contact-list-widget.h 0ab5449 
  contact-list-widget.cpp 1bdf635 
  main-widget.h 8dab6e0 
  main-widget.cpp b9129fa 

Diff: http://git.reviewboard.kde.org/r/111387/diff/


Testing
-------

Selecting different contact combinations properly sets the KDualAction.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130912/7453ea1e/attachment.html>


More information about the KDE-Telepathy mailing list