Review Request 112658: Draw branches for contacts in KPeople mode

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112658/#review39832
-----------------------------------------------------------


I wouldn't mind the branches being drawn, but I like the look without branches as well. The question for me is: Are we the only KDE application who hides the branch lines? If so, we'd need a very good argument for breaking consistency with other KDE apps. If others do it as well for similar reasons we do it, it would be okay.

The only problem I have with either way of representing it: If users have no expanding contacts (e.g. because they use only one IM protocol or because there is zero overlap between contacts of different protocols), they get either a lot of weird-looking whitespace or lots of function-less gray lines for no apparent reason.
Therefore from my perspective ideally we'd use the tree representation only if there are actually any metacontacts with multiple contacts in them. I know this is probably a horrible idea from a code perspective, but this is my personal rainbow pony wish because trees with actually only one level are just stupid, with or without the lines.

- Thomas Pfeiffer


On Sept. 10, 2013, 11:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112658/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 11:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Draw branches for contacts in KPeople mode
> 
> To me it's a lot easier to use and navigate and doesn't look too bad.
> 
> Requires https://git.reviewboard.kde.org/r/112657/
> 
> Fixes 2 of the release blocking bugs.
> 
> (https://bugs.kde.org/show_bug.cgi?id=324602 and https://bugs.kde.org/show_bug.cgi?id=324300)
> These could be solved in other ways, for me this patch is mostly about fixing the problem of double clicking expanding (not reported).
> 
> 
> Diffs
> -----
> 
>   contact-delegate-compact.cpp 945def1565707691072fbcd62b70756ee4e3ee84 
>   contact-list-widget.cpp 7c4c9308940828a923d3c196af51c12314114257 
>   contact-list-widget_p.h 5baae8776702c9f0f8aa78584a04ef402dea1d61 
> 
> Diff: http://git.reviewboard.kde.org/r/112658/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/facebook1.png
> Just arrows, no lines.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/arrows1_1.png
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/fb1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130911/774b13e7/attachment.html>