Review Request 112658: Draw branches for contacts in KPeople mode

[Thomas Pfeiffer]

> On Sept. 10, 2013, 10:19 p.m., Martin Klapetek wrote:
> > I personally don't like it. Maybe if the first level was indented at 0, it could work, but this would loose the expand/collapse signs.
> > 
> > (Originally I took the contact list delegate task to make sure it wouldn't have the tree branches as it looks...well, just like kopete.)
> 
> David Edmundson wrote:
>     Well we don't have them pointlessly on the group headers, so it's still one up from Kopete :)
>     
>

Seriously, please, do not ever use "looks just like Kopete" as an argument against something again. Arguments like this might be common in the competitive world of proprietary software, but these arguments should never come up in Free Software. We do not have to differentiate ourselves from Kopete just for the sake of differentiation.
"Kopete has often been criticized for the branches in their contact list, so we do not want to repeat their mistakes" would be a good argument if it was true, but "we don't want to look like Kopete" is a horribly bad argument.
We should learn both from Kopete's mistakes and from their successes (as I say again and again, Kopete does a lot of things right. It was in fact my favorite IM client before KTp came around).
If you think Kopete does something bad, you should find arguments to support that position.
Thank you!


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112658/#review39780
-----------------------------------------------------------


On Sept. 10, 2013, 11:56 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112658/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 11:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Draw branches for contacts in KPeople mode
> 
> To me it's a lot easier to use and navigate and doesn't look too bad.
> 
> Requires https://git.reviewboard.kde.org/r/112657/
> 
> Fixes 2 of the release blocking bugs.
> 
> (https://bugs.kde.org/show_bug.cgi?id=324602 and https://bugs.kde.org/show_bug.cgi?id=324300)
> These could be solved in other ways, for me this patch is mostly about fixing the problem of double clicking expanding (not reported).
> 
> 
> Diffs
> -----
> 
>   contact-delegate-compact.cpp 945def1565707691072fbcd62b70756ee4e3ee84 
>   contact-list-widget.cpp 7c4c9308940828a923d3c196af51c12314114257 
>   contact-list-widget_p.h 5baae8776702c9f0f8aa78584a04ef402dea1d61 
> 
> Diff: http://git.reviewboard.kde.org/r/112658/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> 
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/facebook1.png
> Just arrows, no lines.
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/arrows1_1.png
> Before
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/fb1.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130911/eae4180c/attachment.html>