Review Request 112657: Supress unused kpeople rows the proxy mode

Aleix Pol Gonzalez aleixpol at kde.org
Tue Sep 10 22:42:43 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112657/#review39786
-----------------------------------------------------------

Ship it!


Ship It!

- Aleix Pol Gonzalez


On Sept. 10, 2013, 8:40 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112657/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 8:40 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Supress unused kpeople rows the proxy mode
> 
> KPeople has a tree structure for all contacts to single contacts have a root
> entry and 1 child node.
> 
> This looks silly when displayed so we supress the child node.
> Currently this happens in the contact list delegate.
> 
> This moves it to the model which is a bit cleaner
> 
> 
> Diffs
> -----
> 
>   KTp/Models/kpeopletranslationproxy.cpp a9bce378271006a9003c7757e49ba5b76ea97223 
>   KTp/Models/kpeopletranslationproxy.h 16dbd0733415e373e17dca624bd21a7ee8481048 
> 
> Diff: http://git.reviewboard.kde.org/r/112657/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130910/a694d0df/attachment.html>


More information about the KDE-Telepathy mailing list