Review Request 112658: Draw branches for contacts in KPeople mode
Martin Klapetek
martin.klapetek at gmail.com
Tue Sep 10 22:19:10 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112658/#review39780
-----------------------------------------------------------
I personally don't like it. Maybe if the first level was indented at 0, it could work, but this would loose the expand/collapse signs.
(Originally I took the contact list delegate task to make sure it wouldn't have the tree branches as it looks...well, just like kopete.)
- Martin Klapetek
On Sept. 10, 2013, 8:49 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112658/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2013, 8:49 p.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Draw branches for contacts in KPeople mode
>
> To me it's a lot easier to use and navigate and doesn't look too bad.
>
> Requires https://git.reviewboard.kde.org/r/112657/
>
> Fixes 2 of the release blocking bugs.
>
>
> Diffs
> -----
>
> contact-delegate-compact.cpp 945def1565707691072fbcd62b70756ee4e3ee84
> contact-list-widget.cpp 7c4c9308940828a923d3c196af51c12314114257
>
> Diff: http://git.reviewboard.kde.org/r/112658/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/10/facebook1.png
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130910/68998556/attachment.html>
More information about the KDE-Telepathy
mailing list