Review Request 112597: Add support for ktp-active to set user typing status

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112597/#review39732
-----------------------------------------------------------

Ship it!


Thanks

I'd think it would be better if you were to implement your TODO, we can then make it a property rather than 3 slots. Which will make the code even neater.

You can either ship this or make that change. I'll leave the decision up to you.




KTp/Declarative/conversation.h
<http://git.reviewboard.kde.org/r/112597/#comment29250>

    I thought we were going to do this?


- David Edmundson


On Sept. 10, 2013, 3:29 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112597/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 3:29 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Added functions for setting user typing status
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversation.h 6f50709 
>   KTp/Declarative/conversation.cpp 8284d81 
> 
> Diff: http://git.reviewboard.kde.org/r/112597/diff/
> 
> 
> Testing
> -------
> 
> tested, works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130910/e14fb68a/attachment.html>