Review Request 112631: Fix add account empty combo box

[Sven Brauch]

> On Sept. 10, 2013, 12:02 p.m., Commit Hook wrote:
> > This review has been submitted with commit 73f27b0f301ad17a16770aef016ab8c86e31e64b by David Edmundson to branch master.

When this is reverted, consider reverting 9c4fdda too, it'll probably become unneded then.


- Sven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112631/#review39716
-----------------------------------------------------------


On Sept. 10, 2013, 12:02 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112631/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 12:02 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> https://bugs.kde.org/show_bug.cgi?id=324698
> 
> Having finished this patch I've realised this is totally the wrong solution to a problem that shouldn't exist.
> 
> It turns out we only get this bug because kpeople is using a separate account manager to the main contact list, which is wrong. I'm sure I've said many times about how we shouldn't put two account managers in the same application because we'll get weird problems. Clearly not enough times.
> 
> I have a plan to fix that properly with singleton returning standard factories..but it's too late to do that in 0.7. There's no other public way to share the account factory.
> 
> I think maybe we should ship this, and I'll remove it in 0.8? Thoughts?
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/add-contact-dialog.h c12834a 
>   KTp/Widgets/add-contact-dialog.cpp fb34eb5 
> 
> Diff: http://git.reviewboard.kde.org/r/112631/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130910/942091d5/attachment.html>