Review Request 112599: Add modelInitialized() signal to KTp::ContactsModel

[David Edmundson]

> On Sept. 9, 2013, 10:15 a.m., David Edmundson wrote:
> > KTp/Models/contacts-list-model.cpp, line 210
> > <http://git.reviewboard.kde.org/r/112599/diff/1/?file=188403#file188403line210>
> >
> >     I think there may be potential to emit this when only the first contact manager out of several is loaded.
> >     
> >
> 
> Dan Vrátil wrote:
>     I'm not sure I follow - d->initialized is set to true immediately after this, so it will emitted only once...?

If we have 4 accounts as soon as the account's connection is established (in GlobalContactManager) we emit contactsChanged() at which point we say the model is ready. Rather than when all 4 are ready.
That might cause a problem for your model merging? 


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112599/#review39629
-----------------------------------------------------------


On Sept. 9, 2013, 10:28 a.m., Dan Vrátil wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112599/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 10:28 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Lorem Ipsum.
> 
> 
> Diffs
> -----
> 
>   KTp/Models/contacts-model.cpp 8a1b0d6 
>   KTp/Models/contacts-list-model.cpp 9a1b532 
>   KTp/Models/contacts-model.h 345378b 
>   KTp/Models/contacts-list-model.h 876a485 
> 
> Diff: http://git.reviewboard.kde.org/r/112599/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dan Vrátil
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130909/bf19ba7f/attachment-0001.html>