Review Request 112596: Enable ktp-active to set typing status of user

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112596/#review39625
-----------------------------------------------------------


Nice work! Few minor comments


application/package/contents/ui/Chat/Chat.qml
<http://git.reviewboard.kde.org/r/112596/#comment29191>

    You could change it to onTextChanged which would fix your comment.
    
    All properties in QML have an automatic signal
    
    on PropertyName Changed
    
    it will also fix my second comment.



application/package/contents/ui/Chat/Chat.qml
<http://git.reviewboard.kde.org/r/112596/#comment29194>

    remove this at some point, console.logs slow things down.



application/package/contents/ui/Chat/Chat.qml
<http://git.reviewboard.kde.org/r/112596/#comment29195>

    well done for removing this :D



application/package/contents/ui/Chat/Chat.qml
<http://git.reviewboard.kde.org/r/112596/#comment29192>

    There's a bug here. 
    
    if you're typing away then send the message and then don't press anything after 5 seconds it will set it as paused.


- David Edmundson


On Sept. 9, 2013, 6:47 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112596/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 6:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Detect and set user typing status
> 
> 
> Diffs
> -----
> 
>   application/package/contents/ui/Chat/Chat.qml 708bae6 
> 
> Diff: http://git.reviewboard.kde.org/r/112596/diff/
> 
> 
> Testing
> -------
> 
> tested using second chat client, works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130909/e6a7e497/attachment-0001.html>