Review Request 112597: Add support for ktp-active to set user typing status

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112597/#review39626
-----------------------------------------------------------



KTp/Declarative/messages-model.h
<http://git.reviewboard.kde.org/r/112597/#comment29193>

    I would rather move these to Conversation not MessagesModel so we can keep this as a model of messages.
    
    (I know by that logic sendMessage doesn't belong here but long term I want to move that too)
    
    
    as for your TODO, there are two approaches:
     - either we expose Tp::TextChannel::ChatState to QML, and use that as the parameter.
    
     - we have "updateIsTyping(bool)
    and move the timer code into C++. (i.e we call updateIsTyping(true) every time they press a key.) 
    
    or we leave it as-is.


- David Edmundson


On Sept. 9, 2013, 6:47 a.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112597/
> -----------------------------------------------------------
> 
> (Updated Sept. 9, 2013, 6:47 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Added functions for setting user typing status
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/messages-model.h a0f1565 
>   KTp/Declarative/messages-model.cpp 9cf1606 
> 
> Diff: http://git.reviewboard.kde.org/r/112597/diff/
> 
> 
> Testing
> -------
> 
> tested, works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130909/407fdd68/attachment.html>