Review Request 112588: Jabber groupchat: Do not display the full jid - display the room name
Frank Meerkoetter
frank at meerkoetter.org
Sun Sep 8 11:33:29 UTC 2013
> On Sept. 8, 2013, 11:05 a.m., David Edmundson wrote:
> > Good stuff.
> >
> > In future always set the group to telepathy and there's no point setting my name explicitly as I see everything.
> >
> > Do you have commit access?
I was not sure about the group name. Review board wasn't offering me auto-complete.
I don't have write access yet.
- Frank
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112588/#review39575
-----------------------------------------------------------
On Sept. 8, 2013, 10:56 a.m., Frank Meerkoetter wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112588/
> -----------------------------------------------------------
>
> (Updated Sept. 8, 2013, 10:56 a.m.)
>
>
> Review request for Telepathy and David Edmundson.
>
>
> Description
> -------
>
> ktp-text-ui is currently using the full jid as title (instead of the real room name) of chat-widgets. This is taking up a lot of screen-real-estate (someroom at conference.jabbber.ccc.de vs. someroom). If i open ~3 chatrooms i am forced to constantly screen through my tabs.
>
> This patch provides a workaround by stripping the host-part from the jid. A real solution would be to extend QtTp to provide the Telepathy roomname property.
>
>
> Diffs
> -----
>
> lib/chat-widget.cpp 25602ba
>
> Diff: http://git.reviewboard.kde.org/r/112588/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Frank Meerkoetter
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130908/2c4bc1c7/attachment.html>
More information about the KDE-Telepathy
mailing list