Review Request 112549: Add kpeople plugin to show IM contacts in show details view

[David Edmundson]

> On Sept. 6, 2013, 2:03 a.m., Aleix Pol Gonzalez wrote:
> > kpeople/uiplugins/imdetailswidget.cpp, line 86
> > <http://git.reviewboard.kde.org/r/112549/diff/1-2/?file=187411#file187411line86>
> >
> >     Use QStyle::PM_SmallIconSize? :D
> >     KIconLoader::Small is doubtfully better than a scalar and it's deprecated in KF5.

KIconLoader::Small uses the user defined icon sizes in systemsettings so it's considerably better than hardcoding

Under oxygen QStyle::pixelMetric calls KIconLoader, so it ends up being the same thing.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112549/#review39448
-----------------------------------------------------------


On Sept. 6, 2013, 1:37 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112549/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 1:37 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add kpeople plugin to show IM contacts in show details view
> 
> 
> Diffs
> -----
> 
>   kpeople/CMakeLists.txt 10c3758aa0fd54177595a69afd4eb899664b4193 
>   kpeople/uiplugins/CMakeLists.txt PRE-CREATION 
>   kpeople/uiplugins/imdetailswidget.h PRE-CREATION 
>   kpeople/uiplugins/imdetailswidget.cpp PRE-CREATION 
>   kpeople/uiplugins/imdetailswidgetplugin.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112549/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of show info dialog
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/snapshot2_2.png
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130906/b6221135/attachment.html>