Review Request 112549: Add kpeople plugin to show IM contacts in show details view
Aleix Pol Gonzalez
aleixpol at kde.org
Fri Sep 6 00:35:07 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112549/#review39445
-----------------------------------------------------------
I think it could be useful... but what's the use-case?
Maybe we should have one more generic that displays the standard information about the subcontacts instead of just the IM? Like e-mail or phone...
It doesn't seem like you require ktp anyway for what you're showing, right?
- Aleix Pol Gonzalez
On Sept. 6, 2013, 12:05 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112549/
> -----------------------------------------------------------
>
> (Updated Sept. 6, 2013, 12:05 a.m.)
>
>
> Review request for Telepathy.
>
>
> Description
> -------
>
> Add kpeople plugin to show IM contacts in show details view
>
>
> Diffs
> -----
>
> kpeople/CMakeLists.txt 10c3758aa0fd54177595a69afd4eb899664b4193
> kpeople/uiplugins/CMakeLists.txt PRE-CREATION
> kpeople/uiplugins/imdetailswidget.h PRE-CREATION
> kpeople/uiplugins/imdetailswidget.cpp PRE-CREATION
> kpeople/uiplugins/imdetailswidgetplugin.desktop PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/112549/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
>
> http://git.reviewboard.kde.org/media/uploaded/files/2013/09/06/snapshot2_1.png
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130906/6f29fd19/attachment.html>
More information about the KDE-Telepathy
mailing list