Review Request 112549: Add kpeople plugin to show IM contacts in show details view

[Aleix Pol Gonzalez]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112549/#review39442
-----------------------------------------------------------



kpeople/uiplugins/imdetailswidget.cpp
<http://git.reviewboard.kde.org/r/112549/#comment29058>

    setActive(!imAccounts.isEmpty());
    
    Or use isEmpty at least...



kpeople/uiplugins/imdetailswidget.cpp
<http://git.reviewboard.kde.org/r/112549/#comment29059>

    Maybe you can use QFontMetrics?


Can we have a screenshot maybe? :D

- Aleix Pol Gonzalez


On Sept. 5, 2013, 11:37 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112549/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 11:37 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Add kpeople plugin to show IM contacts in show details view
> 
> 
> Diffs
> -----
> 
>   kpeople/CMakeLists.txt 10c3758aa0fd54177595a69afd4eb899664b4193 
>   kpeople/uiplugins/CMakeLists.txt PRE-CREATION 
>   kpeople/uiplugins/imdetailswidget.h PRE-CREATION 
>   kpeople/uiplugins/imdetailswidget.cpp PRE-CREATION 
>   kpeople/uiplugins/imdetailswidgetplugin.desktop PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112549/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130905/aeda287d/attachment-0001.html>