Review Request 112524: Fix offline caused by disconnection is saved as last presence

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112524/
-----------------------------------------------------------

(Updated Sept. 5, 2013, 5:57 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and David Edmundson.


Description
-------

If connection detection is compiled in telepathy-mission-control, it will automatically set account offline thus onRequestedPresenceChanged will be triggered.

As far as I observe, that user requested offline will have connectionStatus still set to online at the time it's triggered if previous status is online.

This patch eliminates the possibility if it's already offline, the lastPresence will not be able to saved as offline, but I think that's something not very important. (manually set offline when it's offline, doesn't make much sense I think).


Diffs
-----

  telepathy-module.cpp 93f2717 

Diff: http://git.reviewboard.kde.org/r/112524/diff/


Testing
-------

disconnect in network manager or error occurs -> last presence not modified
connected and change to offline -> last presence is still remembered.


Thanks,

Xuetian Weng

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130905/2717578c/attachment.html>