Review Request 112393: Populate new contact alias, avatar and groups on initial load

Commit Hook null at kde.org
Mon Sep 2 13:15:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112393/
-----------------------------------------------------------

(Updated Sept. 2, 2013, 1:15 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy and Vishesh Handa.


Description
-------

Populate contact alias avatars and groups on initial load

Whilst this makes fetching data from Telepathy have a slightly higher
latency than inserting minimal data and then updating it the
stress this causes on Nepomuk and in particular anything using the database
having to update everything twice is much greater.

BUG: 322032

--

End result things will be much much faster. Especially if you have the contact list open during initial feeding.


Diffs
-----

  account.cpp c21809ece8e08932565a15adcdb77836da7010ed 
  controller.cpp 0afb5d127c80caa690e7cbde629a95ef80fc9179 
  nepomuk-storage.h a921e22c3315eed2dd825014ee3ae8250a039995 
  nepomuk-storage.cpp 7b05a222555aadf142c74c84cc37078261d56f2e 

Diff: http://git.reviewboard.kde.org/r/112393/diff/


Testing
-------

Disbaled Nepomuk
Wiped database
Enabled Nepomuk
Had contact list open 
Within a minute it had everything populated. 

Contact list crashed a lot (unrelated known bug)


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130902/9a86ba77/attachment-0001.html>


More information about the KDE-Telepathy mailing list