Review Request 112393: Populate new contact alias, avatar and groups on initial load

[Martin Klapetek]

> On Sept. 2, 2013, 7:18 a.m., Martin Klapetek wrote:
> > nepomuk-storage.h, lines 144-146
> > <http://git.reviewboard.kde.org/r/112393/diff/1/?file=185773#file185773line144>
> >
> >     I'm unsure if it's worth adding couple lines of code as new methods, mostly because the API is quite confusing already, this won't help much...also these are not used as slots.
> 
> David Edmundson wrote:
>     If we don't we have duplication of code.
>     I think we'll edit one and not the other and it will all explode.

Fwiw, this class already has lots of code duplicated (even your updateContactGroups() has duplicated parts from setContactGroups(), so it has the same issue)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112393/#review39116
-----------------------------------------------------------


On Aug. 31, 2013, 12:08 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112393/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2013, 12:08 p.m.)
> 
> 
> Review request for Telepathy and Vishesh Handa.
> 
> 
> Description
> -------
> 
> Populate contact alias avatars and groups on initial load
> 
> Whilst this makes fetching data from Telepathy have a slightly higher
> latency than inserting minimal data and then updating it the
> stress this causes on Nepomuk and in particular anything using the database
> having to update everything twice is much greater.
> 
> BUG: 322032
> 
> --
> 
> End result things will be much much faster. Especially if you have the contact list open during initial feeding.
> 
> 
> Diffs
> -----
> 
>   account.cpp c21809ece8e08932565a15adcdb77836da7010ed 
>   controller.cpp 0afb5d127c80caa690e7cbde629a95ef80fc9179 
>   nepomuk-storage.h a921e22c3315eed2dd825014ee3ae8250a039995 
>   nepomuk-storage.cpp 7b05a222555aadf142c74c84cc37078261d56f2e 
> 
> Diff: http://git.reviewboard.kde.org/r/112393/diff/
> 
> 
> Testing
> -------
> 
> Disbaled Nepomuk
> Wiped database
> Enabled Nepomuk
> Had contact list open 
> Within a minute it had everything populated. 
> 
> Contact list crashed a lot (unrelated known bug)
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130902/49c9a936/attachment.html>