Review Request 112438: Merge plugin for SMS CM (pintxo)

[Anant Kamath]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112438/
-----------------------------------------------------------

(Updated Sept. 2, 2013, 3:28 a.m.)


Review request for Telepathy and David Edmundson.


Changes
-------

Used handleParameter and added set function for simIdentifier.


Description
-------

Merge plugin for the SMS connection manager (pintxo)


Diffs (updated)
-----

  data/profiles/sms.profile PRE-CREATION 
  plugins/CMakeLists.txt b2af316891af14232c5aaa3eebcfd17802c6a1ca 
  plugins/pintxo/CMakeLists.txt PRE-CREATION 
  plugins/pintxo/Messages.sh PRE-CREATION 
  plugins/pintxo/ktpaccountskcm_plugin_pintxo.desktop.cmake PRE-CREATION 
  plugins/pintxo/main-options-widget.h PRE-CREATION 
  plugins/pintxo/main-options-widget.cpp PRE-CREATION 
  plugins/pintxo/main-options-widget.ui PRE-CREATION 
  plugins/pintxo/modem-combobox.h PRE-CREATION 
  plugins/pintxo/modem-combobox.cpp PRE-CREATION 
  plugins/pintxo/pintxo-account-ui-plugin.h PRE-CREATION 
  plugins/pintxo/pintxo-account-ui-plugin.cpp PRE-CREATION 
  plugins/pintxo/pintxo-account-ui.h PRE-CREATION 
  plugins/pintxo/pintxo-account-ui.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/112438/diff/


Testing
-------

Builds, works


File Attachments
----------------

Screenshot
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/am1.jpeg


Thanks,

Anant Kamath

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130902/599ec3f6/attachment.html>