Review Request 112438: Merge plugin for SMS CM (pintxo)

[Anant Kamath]

> On Sept. 2, 2013, 12:54 a.m., David Edmundson wrote:
> > plugins/pintxo/modem-combobox.h, line 36
> > <http://git.reviewboard.kde.org/r/112438/diff/1/?file=186181#file186181line36>
> >
> >     do you not also need a set method?
> >     
> >     Otherwise when you edit an account the second time it will show the wrong value.

As per the current behaviour, if the modem that was chosen (or any modem) while creating the account, is not connected when editing, then the combobox will be blank, and not allow you to save the settings.
If there is any modem connected, it will appear in the list, which you can choose as your (new) modem.
I'm not sure a set method is required here?


- Anant


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112438/#review39108
-----------------------------------------------------------


On Sept. 2, 2013, 12:35 a.m., Anant Kamath wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112438/
> -----------------------------------------------------------
> 
> (Updated Sept. 2, 2013, 12:35 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Description
> -------
> 
> Merge plugin for the SMS connection manager (pintxo)
> 
> 
> Diffs
> -----
> 
>   data/profiles/sms.profile PRE-CREATION 
>   plugins/CMakeLists.txt b2af316891af14232c5aaa3eebcfd17802c6a1ca 
>   plugins/pintxo/CMakeLists.txt PRE-CREATION 
>   plugins/pintxo/Messages.sh PRE-CREATION 
>   plugins/pintxo/ktpaccountskcm_plugin_pintxo.desktop.cmake PRE-CREATION 
>   plugins/pintxo/main-options-widget.h PRE-CREATION 
>   plugins/pintxo/main-options-widget.cpp PRE-CREATION 
>   plugins/pintxo/main-options-widget.ui PRE-CREATION 
>   plugins/pintxo/modem-combobox.h PRE-CREATION 
>   plugins/pintxo/modem-combobox.cpp PRE-CREATION 
>   plugins/pintxo/pintxo-account-ui-plugin.h PRE-CREATION 
>   plugins/pintxo/pintxo-account-ui-plugin.cpp PRE-CREATION 
>   plugins/pintxo/pintxo-account-ui.h PRE-CREATION 
>   plugins/pintxo/pintxo-account-ui.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/112438/diff/
> 
> 
> Testing
> -------
> 
> Builds, works
> 
> 
> File Attachments
> ----------------
> 
> Screenshot
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/09/02/am1.jpeg
> 
> 
> Thanks,
> 
> Anant Kamath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130902/29c29dec/attachment.html>