Review Request 112430: Fix crash in AbstractGroupingModel when used in a tree

Commit Hook null at kde.org
Sun Sep 1 19:18:39 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112430/
-----------------------------------------------------------

(Updated Sept. 1, 2013, 7:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Description
-------

Fix crash in AbstractGroupingModel when used in a tree

When removing a proxy item, remove children of that item from the proxy map


Diffs
-----

  KTp/Models/abstract-grouping-proxy-model.cpp 6978d9294300742bff951f13740a5f2572b241b0 

Diff: http://git.reviewboard.kde.org/r/112430/diff/


Testing
-------

Seems to fix that main crash we had in ktp-contact-list. I re-fed all my contacts, used the merge dialog with it open.. no crash.
Though since running this it has still crashed once, however on a different error inside kpeople 


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20130901/0aa97a3c/attachment.html>


More information about the KDE-Telepathy mailing list