Review Request 113228: Use a separate notifyrc file for adiumxtra-protocol-handler

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113228/#review42625
-----------------------------------------------------------

Ship it!


My only concern on this is that we might be dropping this in 0.8 if we merge the QML text-ui. Honestly I don't know how feasible that is, it depends on a lot of other things. I don't want to make translators translate something we're going to delete, because that will annoy them a lot.

Any thoughts? Maybe we could leave it here and only merge it if we don't get the QML UI done in time?

- David Edmundson


On Oct. 13, 2013, 1:38 p.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113228/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 1:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Use a separate notifyrc file for adiumxtra-protocol-handler
> 
> This way, the notification types used as the UI for
> adiumxtra-protocol-handler can be removed from the notification
> configuration dialog for the ktelepathy component.
> 
> 
> Diffs
> -----
> 
>   adiumxtra-protocol-handler/CMakeLists.txt 597fa753377b53f86503739dc670fa0caaf6af50 
>   adiumxtra-protocol-handler/adiumxtra-protocol-handler.cpp 02c3289c15b4cdb2f73f782dbc0d0ee0f58f237a 
>   adiumxtra-protocol-handler/chat-style-installer.cpp 20d0fedf31467a5baa812c7f8ff7813f01c6f305 
>   adiumxtra-protocol-handler/emoticon-set-installer.cpp 690d60c459e1a9aeadb64a11436088abb6b2d9c6 
>   adiumxtra-protocol-handler/ktp-adiumxtra-protocol-handler.notifyrc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/113228/diff/
> 
> 
> Testing
> -------
> 
> To test emoticon set installation: $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler 'adiumxtra://www.adiumxtras.com/download/4207')
> To test message style installation: $(/usr/libexec/kde4/ktp-adiumxtra-protocol-handler 'adiumxtra://www.adiumxtras.com/download/7780')
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131029/58b191db/attachment.html>