Review Request 113448: Split Message Handling out of text-ui into a new class ready for QML drop in later

David Edmundson david at davidedmundson.co.uk
Sun Oct 27 00:59:07 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113448/
-----------------------------------------------------------

Review request for Telepathy.


Repository: ktp-text-ui


Description
-------

commit 655de06f7d218109f365bdbeed4c567b63e45376
Author: David Edmundson <kde at davidedmundson.co.uk>
Date:   Mon Oct 14 14:14:44 2013 -0700

    Fix notifications

commit 28a6ed3b5adcd82449d4e2ee58717ce6b0a27d78
Author: David Edmundson <kde at davidedmundson.co.uk>
Date:   Mon Oct 14 18:47:29 2013 +0000

    Split message handling out of ChatWidget into MessageView
    
    This prepares it ready for moving to the QML message view

commit 77897b72c6c5ef3a9d4d0c3753b7796cdf24768f
Author: David Edmundson <kde at davidedmundson.co.uk>
Date:   Mon Oct 14 18:46:53 2013 +0000

    Rename MessageView -> LogMessageView
    
    (it conflicts with a new class I'm about to add)


Diffs
-----

  lib/CMakeLists.txt 57065228183722b9f5c86ab782a553a4e576c22c 
  lib/chat-widget.h c1dbd41456f1bbb9cc1f54743fa6d839d522aec3 
  lib/chat-widget.cpp c2b5a97e739fc78267a243c8e36a9d6efdb98c1c 
  lib/chat-widget.ui 0985f9c703a2ea34056696fd9265c41432250956 
  lib/message-view.h PRE-CREATION 
  lib/message-view.cpp PRE-CREATION 
  lib/notify-filter.h f929ce3271bb0d0a98e8aab1b74fd3aee5120c70 
  lib/notify-filter.cpp a5c8ba091ade6ece89ec2d3bec2ef24b94cb417f 
  logviewer/CMakeLists.txt 74989d4596952dd6b790cb5b1a803fd7725efbd3 
  logviewer/config/behavior-config.cpp 247c03acc706b799cb58213550f4225a24549666 
  logviewer/log-viewer.ui cb0a313b5e08e2e265c5c5bf76abf8459639c71f 
  logviewer/message-view.h ec592c76f28d7a914808d099febe7ea7eb68ca74 
  logviewer/message-view.cpp 0b137e10e44d277bda6c525dc48e9c4d5953069e 

Diff: http://git.reviewboard.kde.org/r/113448/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131027/e437197c/attachment.html>


More information about the KDE-Telepathy mailing list