Review Request 113354: Show only one active chat [2/2]

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113354/#review42282
-----------------------------------------------------------


Generally perfect. A few minor nitpicks.
(plus the discussion on IRC)


KTp/Declarative/conversations-model.h
<http://git.reviewboard.kde.org/r/113354/#comment30770>

    Either we use d pointers or we have member variables (the m_activeChatIndex)
    
    D pointers explained here: http://zchydem.enume.net/2010/01/19/qt-howto-private-classes-and-d-pointers/
    (actually in this class we technically don't need to do this, but we have anyway)
    
    In short:
     - move m_activeChatIndex to the member variables of 
    ChatWindowPrivate
    
     - find and replace m_activeChatIndex to d->activeChatIndex



KTp/Declarative/conversations-model.cpp
<http://git.reviewboard.kde.org/r/113354/#comment30769>

    "the model is reset"?


- David Edmundson


On Oct. 24, 2013, 1:22 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113354/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2013, 1:22 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Moves/appends the currently requested chat to the end of the list of chats, which is considered the active chat.
> One other way to do this would be to maintain a index variable which carries the active chat index. But I could not find a way to update the model once that index is changed.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversations-model.h 1691238 
>   KTp/Declarative/conversations-model.cpp 630d403 
> 
> Diff: http://git.reviewboard.kde.org/r/113354/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131024/d4c968e1/attachment-0001.html>