Review Request 113354: Show only one active chat [2/2]

[David Edmundson]

> On Oct. 21, 2013, 8:48 p.m., David Edmundson wrote:
> > So every row has a property to say which row is active?
> > That seems awkward.
> 
> Siddhartha Sahu wrote:
>     No there is only one variable, which holds the id of the active chat.
> 
> Martin Klapetek wrote:
>     But to access that one variable you're using model roles, which means that every row in the model has a property (the data coming from that role), that says which row is active.

It may be best to expose ActiveIndex as a Q_PROPERTY on the class, rather than on each role. Should be only a small change.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113354/#review42135
-----------------------------------------------------------


On Oct. 21, 2013, 8:46 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113354/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2013, 8:46 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Moves/appends the currently requested chat to the end of the list of chats, which is considered the active chat.
> One other way to do this would be to maintain a index variable which carries the active chat index. But I could not find a way to update the model once that index is changed.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversations-model.h 1691238 
>   KTp/Declarative/conversations-model.cpp 630d403 
> 
> Diff: http://git.reviewboard.kde.org/r/113354/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131023/79156de9/attachment.html>