Review Request 113331: Make LogViewer's DateModel saner
Leon Handreke
leonh at ndreke.de
Tue Oct 22 17:52:54 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113331/#review42177
-----------------------------------------------------------
Looks good to me and I didn't get it to crash either.
Given my limited knowledge of C++ and Qt, I don't feel qualified to do a style review of this code though.
- Leon Handreke
On Oct. 18, 2013, 3:49 p.m., Dan Vrátil wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113331/
> -----------------------------------------------------------
>
> (Updated Oct. 18, 2013, 3:49 p.m.)
>
>
> Review request for Telepathy and Leon Handreke.
>
>
> Repository: ktp-text-ui
>
>
> Description
> -------
>
> Much nicer and simpler :)
>
>
> Diffs
> -----
>
> logviewer/dates-model.h 773f3b0
> logviewer/dates-model.cpp 93f4814
>
> Diff: http://git.reviewboard.kde.org/r/113331/diff/
>
>
> Testing
> -------
>
> Clicked a few times and nothing crashed.
>
>
> Thanks,
>
> Dan Vrátil
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131022/37d8d101/attachment.html>
More information about the KDE-Telepathy
mailing list