Review Request 113231: Fix move to group in contact list and make it generally faster (1/2)
Martin Klapetek
martin.klapetek at gmail.com
Mon Oct 21 23:46:05 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113231/#review42141
-----------------------------------------------------------
Ship it!
KTp/core.cpp
<http://git.reviewboard.kde.org/r/113231/#comment30699>
Variables in private classes shouldn't have m_ prefix, but oh well...can be fixed together with m_kPeopleEnabled later.
- Martin Klapetek
On Oct. 17, 2013, 9:51 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113231/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2013, 9:51 p.m.)
>
>
> Review request for Telepathy and Martin Klapetek.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> Expose singleton accountmanager
>
>
> Use a separate channelFactory for TextChannelWatcherProxyModel
>
> This ensures that we request the correct features for text channels
> in the clientregistrar rather than relying on the application
> AccountManager
>
>
> Diffs
> -----
>
> KTp/Models/contacts-model.cpp f03ad45
> KTp/core.h 3402fe7
> KTp/core.cpp a0458f9
> KTp/im-persons-data-source.cpp ebd01ba
>
> Diff: http://git.reviewboard.kde.org/r/113231/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> David Edmundson
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131021/018d21ec/attachment-0001.html>
More information about the KDE-Telepathy
mailing list