Review Request 113354: Show only one active chat [2/2]

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113354/#review42029
-----------------------------------------------------------



KTp/Declarative/conversations-model.cpp
<http://git.reviewboard.kde.org/r/113354/#comment30668>

    This is a tiny bit inefficient we loop through Conversations then we find the index of the current conversation.
    We should change the first foreach to a normal for loop then we have the index.



KTp/Declarative/conversations-model.cpp
<http://git.reviewboard.kde.org/r/113354/#comment30669>

    I have a feeling this is going to really break the Chat Plasmoid as that keeps the currentIndex which may break if we move things about.
    
    Also this will mean that the chats in the panel keep moving so the most recent is on the right.
    I don't think we want that (do we?)



KTp/Declarative/conversations-model.cpp
<http://git.reviewboard.kde.org/r/113354/#comment30670>

    If we call beginInsertRows(rowCount, rowCount)
    we can't insert something in a different place.


- David Edmundson


On Oct. 20, 2013, 4:16 p.m., Siddhartha Sahu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113354/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2013, 4:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Moves/appends the currently requested chat to the end of the list of chats, which is considered the active chat.
> One other way to do this would be to maintain a index variable which carries the active chat index. But I could not find a way to update the model once that index is changed.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/conversations-model.cpp 630d403 
> 
> Diff: http://git.reviewboard.kde.org/r/113354/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Siddhartha Sahu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131020/96f31aa4/attachment-0001.html>