Review Request 113222: Handle message delivery reports in MessagesModel
Commit Hook
null at kde.org
Thu Oct 17 22:15:16 UTC 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113222/#review41920
-----------------------------------------------------------
This review has been submitted with commit 99fdc69f95ecda47cefe1053894d9c46a86620c6 by Leon Handreke to branch master.
- Commit Hook
On Oct. 15, 2013, 8:58 p.m., Leon Handreke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113222/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 8:58 p.m.)
>
>
> Review request for Telepathy.
>
>
> Repository: ktp-common-internals
>
>
> Description
> -------
>
> Handle message delivery reports and update original message object with the the new status and possibly an error message.
>
> Introduce a new internal MessagePrivate class to hold extra properties for MessagesModel to avoid having to extend KTp::Message.
>
>
> Diffs
> -----
>
> KTp/Declarative/messages-model.h a0f15653c3644f26dc768fe7ac882b4ac3c91367
> KTp/Declarative/messages-model.cpp 9cf1606555edc7ed9f36970a957a854caf3010a0
>
> Diff: http://git.reviewboard.kde.org/r/113222/diff/
>
>
> Testing
> -------
>
> Only tested receiving a Tp::DeliveryStatusDelivered. Not sure how to test the other cases.
>
>
> Thanks,
>
> Leon Handreke
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131017/995d8cb1/attachment.html>
More information about the KDE-Telepathy
mailing list