Review Request 113289: Fix logviewer crash with multiple conversations per date

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113289/#review41851
-----------------------------------------------------------



logviewer/dates-model.cpp
<http://git.reviewboard.kde.org/r/113289/#comment30543>

    How can the internalId be bigger than m_groups.count() ?
    
    At first glance this looks like a fix for a symptom, not a fix for the cause.
    
    The cause probably being a m_groups is changing but not removing items from the model. (Note: I have not really looked into it and I'm only guessing  ) 
    
    I've added the author the list of people to review this.


- David Edmundson


On Oct. 16, 2013, 11:55 p.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113289/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 11:55 p.m.)
> 
> 
> Review request for Telepathy and Dan Vrátil.
> 
> 
> Bugs: 325957
>     http://bugs.kde.org/show_bug.cgi?id=325957
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Fix logviewer crash with multiple conversations per date
> 
> This situation commonly occurs when conversations from multiple accounts
> were held on a single day.
> 
> 
> Diffs
> -----
> 
>   logviewer/dates-model.cpp 93f4814149094a84d9a822e6618599fe70df3b55 
> 
> Diff: http://git.reviewboard.kde.org/r/113289/diff/
> 
> 
> Testing
> -------
> 
> Test scenario described in the bug.
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131016/419709dd/attachment.html>