Review Request 113222: Handle message delivery reports in MessagesModel

[Leon Handreke]

> On Oct. 14, 2013, 12:22 p.m., Martin Klapetek wrote:
> > KTp/Declarative/messages-model.h, lines 49-50
> > <http://git.reviewboard.kde.org/r/113222/diff/2/?file=200994#file200994line49>
> >
> >     As discussed on IRC before, this could/should drop the "error" and be made more generic for eg. the timestamp of the successful delivery. Otherwise the roles count would be growing and growing.
> >     
> >     Unrelated, would "DeliveryErrorDebugMessageRole" have some user visible data? If so, it shouldn't have "debug" in its name.
> 
> David Edmundson wrote:
>     In this case it's being used to directly pass the message from Telepathy.
>     I'm not sure that is/should be user-visible. It won't be going through i18n like the text-ui does.
>     
>     Maybe that would be a new role
> 
> Martin Klapetek wrote:
>     > I'm not sure that is/should be user-visible.
>     
>     What's the role usecase then? If it's to be outputted somewhere like qDebug(), I guess there's a better way than having it in the model?

I agree with Martin - as long as we haven't figured out a way to display this to anybody but developers, there is no point putting it in the model. I have inserted a kDebug instead.

I also changed deliveryErrorReceiveTime to deliveryReportReceiveTime. This of course comes with the theoretical issue that a UI can't distinguish between when a message was delivered and when it was read, but I suggest we keep it simple for now and add whatever is needed when the time comes.


- Leon


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113222/#review41709
-----------------------------------------------------------


On Oct. 15, 2013, 8:58 p.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113222/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 8:58 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Handle message delivery reports and update original message object with the the new status and possibly an error message.
> 
> Introduce a new internal MessagePrivate class to hold extra properties for MessagesModel to avoid having to extend KTp::Message.
> 
> 
> Diffs
> -----
> 
>   KTp/Declarative/messages-model.h a0f15653c3644f26dc768fe7ac882b4ac3c91367 
>   KTp/Declarative/messages-model.cpp 9cf1606555edc7ed9f36970a957a854caf3010a0 
> 
> Diff: http://git.reviewboard.kde.org/r/113222/diff/
> 
> 
> Testing
> -------
> 
> Only tested receiving a Tp::DeliveryStatusDelivered. Not sure how to test the other cases.
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131015/57b50ed7/attachment.html>