Review Request 113255: Clear sent messages history when clearing chat view

Dan Vrátil dvratil at redhat.com
Tue Oct 15 07:34:48 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113255/
-----------------------------------------------------------

(Updated Oct. 15, 2013, 7:34 a.m.)


Status
------

This change has been marked as submitted.


Review request for Telepathy.


Repository: ktp-text-ui


Description
-------

1) When user clicks Action -> Clear View, clear the sent message history in ChatTextEdit too - when you want to delete a sensitive conversation, keeping sent messages is not a good thing to do :)

2) Fix the actual Clear View action by setting d->exchangedMessagesCount to 0 in clear(), otherwise last X messages from backlog are loaded from logger after re-initializing the chat view.


Diffs
-----

  lib/chat-text-edit.h a14d716 
  lib/chat-text-edit.cpp 684ecd1 
  lib/chat-widget.cpp 71650c2 

Diff: http://git.reviewboard.kde.org/r/113255/diff/


Testing
-------


Thanks,

Dan Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131015/1e056f17/attachment.html>


More information about the KDE-Telepathy mailing list