Review Request 113222: Handle message delivery reports in MessagesModel

Leon Handreke leonh at ndreke.de
Sun Oct 13 22:14:26 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113222/
-----------------------------------------------------------

(Updated Oct. 13, 2013, 10:14 p.m.)


Review request for Telepathy.


Repository: ktp-common-internals


Description
-------

Handle message delivery reports and update original message object with the the new status and possibly an error message.

Introduce a new internal MessagePrivate class to hold extra properties for MessagesModel to avoid having to extend KTp::Message.


Diffs (updated)
-----

  KTp/Declarative/messages-model.h a0f15653c3644f26dc768fe7ac882b4ac3c91367 
  KTp/Declarative/messages-model.cpp 9cf1606555edc7ed9f36970a957a854caf3010a0 

Diff: http://git.reviewboard.kde.org/r/113222/diff/


Testing
-------

Only tested receiving a Tp::DeliveryStatusDelivered. Not sure how to test the other cases.


Thanks,

Leon Handreke

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131013/e420ea4f/attachment.html>


More information about the KDE-Telepathy mailing list