Review Request 113235: Wipe all KTp contacts when we release

Sven Brauch svenbrauch at googlemail.com
Sun Oct 13 18:57:25 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113235/#review41658
-----------------------------------------------------------


Does that mean all my metacontacts will be cleared? Why is that necessary?

The code looks fine based on my limited knowledge.

- Sven Brauch


On Oct. 13, 2013, 6:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113235/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 6:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Wipe all KTp contacts when we release
> 
> This is needed if we ship https://git.reviewboard.kde.org/r/112970/ for 0.7.0.
> 
> 
> Diffs
> -----
> 
>   kpeople/nepomuk-feeder/controller.h b358c8e 
>   kpeople/nepomuk-feeder/controller.cpp fa37b7e 
> 
> Diff: http://git.reviewboard.kde.org/r/113235/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131013/6aea0609/attachment.html>


More information about the KDE-Telepathy mailing list