Review Request 113227: Fix display of conversation logs from multiple accounts in log viewer

Commit Hook null at kde.org
Sun Oct 13 13:09:41 UTC 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113227/#review41640
-----------------------------------------------------------


This review has been submitted with commit 79731ba005b91ee48335369cdfdbb72a6ae1974b by Leon Handreke to branch master.

- Commit Hook


On Oct. 13, 2013, 11:43 a.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113227/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 11:43 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Fix display of conversation logs from multiple accounts in log viewer
> 
> Trying to view logs in a case where conversations from multiple accounts
> with a single person on the same date exist would crash ktp-log-viewer.
> 
> 
> Diffs
> -----
> 
>   logviewer/dates-model.cpp d8878418fa715437b3ec63673ecfe432d2e83df2 
> 
> Diff: http://git.reviewboard.kde.org/r/113227/diff/
> 
> 
> Testing
> -------
> 
> Clicked the account name (in the Date -> Account tree in the log viewer), conversation on that date from that account with that person displays correctly instead of crashing.
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131013/0017ffa6/attachment.html>


More information about the KDE-Telepathy mailing list