Review Request 113227: Fix display of conversation logs from multiple accounts in log viewer

David Edmundson david at davidedmundson.co.uk
Sun Oct 13 10:41:44 UTC 2013



> On Oct. 13, 2013, 10:36 a.m., David Edmundson wrote:
> > Brilliant.

could you put in the 0.7 branch too. 

You have commit access now, you can push these yourself.
Ping me if you want help learning how to do this.

Make sure to add the line REVIEW: 113227 to your commit message.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113227/#review41630
-----------------------------------------------------------


On Oct. 13, 2013, 10:02 a.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113227/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 10:02 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Fix display of conversation logs from multiple accounts in log viewer
> 
> Trying to view logs in a case where conversations from multiple accounts
> with a single person on the same date exist would crash ktp-log-viewer.
> 
> 
> Diffs
> -----
> 
>   logviewer/dates-model.cpp d8878418fa715437b3ec63673ecfe432d2e83df2 
> 
> Diff: http://git.reviewboard.kde.org/r/113227/diff/
> 
> 
> Testing
> -------
> 
> Clicked the account name (in the Date -> Account tree in the log viewer), conversation on that date from that account with that person displays correctly instead of crashing.
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131013/a10ea286/attachment.html>


More information about the KDE-Telepathy mailing list