Review Request 113134: Introduce new notification types for messages received in group chats

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113134/#review41308
-----------------------------------------------------------


Needs update to notifyrc file and testing.

There are now 8 different entries to the notification configuration (from 3) for receiving messages these all need to be added. 
IMHO this is maybe a bit too fine grained control, but as long as the defaults are OK I don't care.

Note changes to notifyrc file will be an i18n change so this will be for 0.8


- David Edmundson


On Oct. 6, 2013, 4:56 p.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113134/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2013, 4:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 289348
>     http://bugs.kde.org/show_bug.cgi?id=289348
> 
> 
> Repository: ktp-text-ui
> 
> 
> Description
> -------
> 
> Introduce new notification types for messages received in group chats
> 
> As a side-effect, there is now also a separate event type for
> highlights received in an active window.
> 
> 
> Diffs
> -----
> 
>   lib/notify-filter.cpp a5c8ba091ade6ece89ec2d3bec2ef24b94cb417f 
> 
> Diff: http://git.reviewboard.kde.org/r/113134/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131006/9fedcbae/attachment-0001.html>