Review Request 113111: Make favorite chat room names editable

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113111/#review41257
-----------------------------------------------------------


This changes the behaviour of double clicking that list. Joining the room is probably going to be a more common action that editing a name. 

Maybe we could have an "Edit" button that does view->edit(view->selectedIndex()); to trigger your edit mode?

Thoughts?



KTp/Models/rooms-model.cpp
<http://git.reviewboard.kde.org/r/113111/#comment30253>

    If someone gives you a different role name, not in this list you return true when you shouldn't.
    
    Probably a non-issue.



KTp/Widgets/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/113111/#comment30251>

    Minor optimisation, these can be marked as const refs.
    const QString &favoriteHandle = 
    
    you can do this if you don't change things and the compiler can make some optimisations and avoid some copying.


- David Edmundson


On Oct. 4, 2013, 9:04 p.m., Leon Handreke wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113111/
> -----------------------------------------------------------
> 
> (Updated Oct. 4, 2013, 9:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Bugs: 308210
>     http://bugs.kde.org/show_bug.cgi?id=308210
> 
> 
> Repository: ktp-common-internals
> 
> 
> Description
> -------
> 
> Make favorite chat room names editable
> 
> 
> Diffs
> -----
> 
>   KTp/Widgets/join-chat-room-dialog.cpp 3f860051b46e33a565b5889a95d759a6feaa06a2 
>   KTp/Widgets/join-chat-room-dialog.h c996e76562c6cda5f12fae5dcf085dd50e4eda94 
>   KTp/Models/rooms-model.cpp 4c3bb4f3d2fe613fc3ae6c978f9b680f782be16b 
>   KTp/Models/rooms-model.h 26301412e1c95c1519c85ed0f3a35f311f38bd20 
> 
> Diff: http://git.reviewboard.kde.org/r/113111/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Leon Handreke
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20131004/83087d64/attachment.html>